Add a quoting API inspired by Ppx_deriving #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a hygiene API in the spirit of Ppx_deriving.quoter. The main differences are: * We can't use metaquot * There are no optional arguments * We don't wrap stuff with modules as this can be easily handled separately Signed-off-by: Rudi Grinberg <[email protected]>
|
It seems like I'm unable to |
ghost
suggested changes
Sep 4, 2019
|
Not sure about the install_printer problem. We should switch all these tests to ppx_expect at some point anyway |
Signed-off-by: Rudi Grinberg <[email protected]>
|
I've written up some docs. Shall I rename the module to |
Signed-off-by: Jeremie Dimino <[email protected]>
|
|
Signed-off-by: Rudi Grinberg <[email protected]>
|
@diml I renamed it. |
|
And for people who might be watching this PR: we are adding this module to make it easier to port plugins from |
|
Thanks for the review, I'll prepare a corresponding PR to ppx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a hygiene API in the spirit of Ppx_deriving.quoter.
The main differences are:
separately