Reintroduce a Ppx_deriving_runtime Result module for compat #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
fix-runtime-result
branch
from
33b7f85 to
fdafbd1
Compare
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Apr 17, 2024
CHANGES: * Fix the unintentional removal of `Ppx_deriving_runtime.Result` in ocaml-ppx/ppx_deriving#279 ocaml-ppx/ppx_deriving#282 (@NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing our unneeded dependency on the
resultcompat package, we inadvertently remove theResultmodule inPpx_deriving_runtimewhich broke its API.This should fix the issue we ran into when attempting to release 6.0.0.