Add support for WebAssembly builds of some 3p-packages #284
Conversation
Signed-off-by: guillaume-haerinck <[email protected]>
|
|
||
| cmake_generate_cmd = [self.cmake_command, | ||
| # emcmake self configure the proper environment when targeting WebAssembly | ||
| cmake_command = self.cmake_command |
There was a problem hiding this comment.
I am unsure about this approach, we might want to setup the same environment as emcmake is doing in the configure json file. Yet this is the easiest and lowest maintenance path so I let the build system pro decide on what is best
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
guillaume-haerinck
changed the title
| @@ -1 +1,2 @@ | |||
| package-system/Crashpad/add_o3de_handler_extensions.patch eol=lf | |||
There was a problem hiding this comment.
.gitattributes files can be in any folder, why not put this in a .gitattributes file in the same folder as the file it affects?
| "custom_additional_compile_definitions":[ | ||
| "GTEST_HAS_TR1_TUPLE=0", | ||
| "GTEST_OS_SUPPORTS_DEATH_TEST=0" | ||
| ] |
There was a problem hiding this comment.
I'm under the impression that we now build googletest as an inline fetchcontent build, this package is unused. see Code\Framework\AzTest\3rdParty\Findgoogletest.cmake
package_build_list_host_windows.json
Outdated
| "googlebenchmark-1.7.0-rev1-windows": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googlebenchmark --platform-name Windows --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-android": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Android --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-windows": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Windows --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-emscripten": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Emscripten --package-root ../../package-system --clean", |
There was a problem hiding this comment.
As above.. you can do this, but the engine doesn't use it.
Signed-off-by: guillaume-haerinck <[email protected]>
|
Noted just updated the files following your feedbacks :) |
Signed-off-by: guillaume-haerinck <[email protected]>
|
This looks good, but how do we want to proceed with this, should we keep this alive while the emscripten changes happen on o3de, until its all in, or do you expect no further revisions of this package need be made? |
2 participants
What does this PR do?
Allow to build several 3p package to the WebAssembly target thanks to emscripten compiler
Related to :
What remains :
How was this PR tested?
Local build on windows.
Setup required for now:
Steps:
python .\build_package.py --search_path ..\..\3p-package-source Lua-5.4.4-rev1-emscriptenemcmake cmake .. -DLY_3RDPARTY_PATH=YOUR_PATHthen build the test targets)