Fix skip_template & skip_secret_template options. Reorder manifest apply #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make the
skip_template
andskip_secret_template
options functional. They currently do not work and still attempt to run when they are set to true.The application order of the two manifest files was also changes so that the
secret_template
manifest is applied prior to thetemplate
manifest since the resources in thetemplate
manifest may need to use the secrets added by thesecret_template
.Changes:
skip_template
is set totrue
in theapplyManifests
function to skip the k8s manifest set intemplate
. This will also skip dry runsapplyManifests
function to check if thetemplate
variable is empty prior to applying changesskip_secret_template
is set totrue
in theapplyManifests
function to skip the k8s manifest set insecret_template
. This will also skip dry runsapplyManifests
function to check if thesecret_template
variable is empty prior to applying changessecret_template
manifest is applied before thetemplate
manifest. This is a dependency issue where some of the k8s resources from thetemplate
manifest will need to have access to the secrets from thesecret_template
manifestskip_template: true
skip_secret_template: true
skip_template: true, skip_secret_template: true
skip_template: true, dry_run: true
skip_secret_template: true, dry_run: true
skip_template: true, skip_secret_template: true, dry_run: true
DOCS.md
to be more explicit about above changesIf this is a change to the core functionality, did you make a corresponding PR to drone-eks?
Did you update the tests?
Did you update the docs?