Skip to content

Conversation

@Flexksx
Copy link

@Flexksx Flexksx commented May 5, 2025

No description provided.

Copy link
Owner

@nwg-piotr nwg-piotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see nothing in this mess. Remove .pyc files, please.

@Flexksx
Copy link
Author

Flexksx commented May 5, 2025

@nwg-piotr oh sorry I should've marked it as draft, it's not ready yet

@nwg-piotr
Copy link
Owner

You mustn't give me 45 files in your PR. All the project does not have that many. Also:

image

No idea where it comes from.

@Flexksx
Copy link
Author

Flexksx commented May 11, 2025

Sorry man I thought of refactoring it because it's honestly hard to understand and it'll be easier in the future to add other features

@Flexksx Flexksx changed the title Persistant profiles Add persistant profiles May 20, 2025
@Flexksx Flexksx closed this May 20, 2025
@Flexksx Flexksx force-pushed the persistant-profiles branch from 9e1d7b2 to de87582 Compare May 20, 2025 10:39
@Flexksx Flexksx reopened this May 20, 2025
@Flexksx Flexksx requested a review from nwg-piotr May 20, 2025 14:27
@Flexksx
Copy link
Author

Flexksx commented May 25, 2025

2025-05-25.20-02-19.mp4

Demo

@Flexksx
Copy link
Author

Flexksx commented May 27, 2025

hey @nwg-piotr could you review it please?

Copy link
Owner

@nwg-piotr nwg-piotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you do to the -w | --workspaces_path argument?

Traceback (most recent call last):
  File "/home/piotr/Clones/nwg-displays/nwg_displays/main.py", line 1517, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/piotr/Clones/nwg-displays/nwg_displays/main.py", line 1200, in main
    workspaces_path = args.workspaces_path
                      ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'workspaces_path'

@Flexksx
Copy link
Author

Flexksx commented May 28, 2025

oopsie daisy

@Flexksx
Copy link
Author

Flexksx commented May 28, 2025

restored it

@nwg-piotr
Copy link
Owner

Looks not bad, but seems to be buggy.

This is my setup:

image

I saved my old configuration to the 'dom-stary' profile. Then I rotated HDMI-A-1 270 degrees (instead of 90) and saved it as the 'dom-bledny' profile. Now when I load the 'dom-bledny' profile, HDMI-A-1 appears over eDP-1 (the same place, dimensions, rotation etc.). Meanwhile what's stored in dom-bledny.json is correct:

    {
      "name": "HDMI-A-1",
      "description": "AOC 2475WR F17H4QA000449",
      "x": 0,
      "y": 0,
      "physical_width": 1920,
      "physical_height": 1200,
      "transform": "270",
      "scale": 1.0,
      "scale_filter": null,
      "refresh": 59.95,
      "dpms": true,
      "adaptive_sync": false,
      "custom_mode": false,
      "mirror": "",
      "ten_bit": false,
      "active": true
    }

Looks as if it assigned eDP-1 data to HDMI-A-1 as well, instead of its proper data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants