Skip to content

Conversation

Saghen
Copy link
Contributor

@Saghen Saghen commented Mar 28, 2025

Opening as draft since I have yet to verify everything works as expected

Closes #1331

@cmdrrobin
Copy link
Contributor

cmdrrobin commented Mar 29, 2025

Tested and works fine. Although before nvim-cmp, it shows the documentations. Maybe we need to enable for blink.cmp as well.

opts = {
  completion = {
    -- Show documentation when available, with a small delay.
    -- If you're noticing high CPU usage or stuttering when opening the
    -- documentation, you may try setting
    -- `completion.documentation.treesitter_highlighting = false`.
    documentation = {
      auto_show = true,
      auto_show_delay_ms = 200,
    },
  },
}

UPDATE: don't know if it is my system, but couldn't trigger show/hide documents with default keymaps. (<C-Space>)

@raRaRa
Copy link

raRaRa commented Apr 6, 2025

What's the status on this? :)

@oriori1703
Copy link
Contributor

fwiw, I have been using a version of this PR for over a week, and experienced no issues :D

@Saghen Saghen marked this pull request as ready for review April 6, 2025 20:06
@Saghen
Copy link
Contributor Author

Saghen commented Apr 6, 2025

Although before nvim-cmp, it shows the documentations. Maybe we need to enable for blink.cmp as well.

I've left this off by default but included a section about turning it on. This matches the behavior of built in completions and other major editors (i.e. vscode). I personally prefer the <C-Space> binding to show it as needed.

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

This looks brilliant.

Not sure how to evaluate this versus the 'default completion' PR.

I know I personally would rather see new users have this experience but I haven't honestly tried the default yet so I'll go test and and report back, and see if we can't get this resolved with a modicum of screaming :)

Thank you!

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

This is so very slightly slower than the 'native' completions as shown in the PR from @cmdrrobin .

However I personally favor the vastly increased flexibility available with different providers and the like.

Thus far I've seen way more strenuous opinions around a desire for the native completions support so I'm feeling rather like King Solomon at the moment :)

@Saghen
Copy link
Contributor Author

Saghen commented Apr 9, 2025

This is so very slightly slower than the 'native' completions

What the hell, sounds like I have some work for the weekend :) Which LSP?

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

basedpyright. This is just my perception and I didn't do any formal benchmarking.

I'm not sure HOW I'd benchmark the two actually. I should look into that :)

@cmdrrobin
Copy link
Contributor

@feoh to be honest, I don't think it is worth the benchmark the two actually. ;-)

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

You know what? I've seen several votes in favor of this PR and we don't have anyone who can support the 'native' version, so with thanks to @cmdrrobin and @Saghen for their hard work and participation I'm merging this.

Great work all!

@feoh feoh merged commit d350db2 into nvim-lua:master Apr 9, 2025
1 check passed
@Saghen Saghen deleted the blink-cmp branch April 9, 2025 22:33
dribic pushed a commit to dribic/nvim-files that referenced this pull request Apr 10, 2025
dimitrov-anasoft pushed a commit to dimitrov-anasoft/kickstart.nvim that referenced this pull request Apr 10, 2025
faizfrhn added a commit to faizfrhn/kickstart.nvim that referenced this pull request Apr 11, 2025
* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
vencronys pushed a commit to vencronys/kickstart.nvim that referenced this pull request Apr 12, 2025
DerFrZocker pushed a commit to DerFrZocker/.dotfiles-nvim that referenced this pull request Apr 12, 2025
1334 added a commit to 1334/kickstart.nvim that referenced this pull request Apr 13, 2025
feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
Jidou pushed a commit to Jidou/kickstart.nvim that referenced this pull request Apr 14, 2025
mascanio pushed a commit to mascanio/kickstart.nvim that referenced this pull request Apr 17, 2025
chrisBosse pushed a commit to chrisBosse/kickstart.nvim that referenced this pull request Apr 17, 2025
tinder-ryantrontz pushed a commit to tinder-ryantrontz/kickstart.nvim that referenced this pull request Apr 21, 2025
nickgnd pushed a commit to nickgnd/kickstart.nvim that referenced this pull request Apr 21, 2025
mirite pushed a commit to mirite/kickstart.nvim that referenced this pull request Apr 22, 2025
vantmet pushed a commit to vantmet/kickstart.nvim that referenced this pull request Apr 24, 2025
WaterAtTheBottomOfTheOcean pushed a commit to WaterAtTheBottomOfTheOcean/kickstart.nvim that referenced this pull request May 30, 2025
audunhov pushed a commit to audunhov/kickstart.nvim that referenced this pull request May 30, 2025
ruolis pushed a commit to ruolis/kickstart.nvim that referenced this pull request Jun 10, 2025
rsandtner pushed a commit to rsandtner/kickstart.nvim that referenced this pull request Jun 11, 2025
invalidoperation pushed a commit to invalidoperation/kickstart.nvim that referenced this pull request Jun 14, 2025
invalidoperation pushed a commit to invalidoperation/kickstart.nvim that referenced this pull request Jun 14, 2025
screwage pushed a commit to screwage/kickstart.nvim that referenced this pull request Jun 17, 2025
Kilo-Loco pushed a commit to Kilo-Loco/kickstart.nvim that referenced this pull request Jun 24, 2025
julianbopp pushed a commit to julianbopp/kickstart.nvim that referenced this pull request Jun 26, 2025
DannyHo15 pushed a commit to DannyHo15/kickstart.nvim that referenced this pull request Jun 29, 2025
knownasnaffy added a commit to knownasnaffy/kickstart.nvim that referenced this pull request Jul 3, 2025
codemedic added a commit to codemedic/kickstart.nvim that referenced this pull request Jul 10, 2025
* master:
  Update remaining Mason's old address (nvim-lua#1530)
  fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)
  README: mention fd-find in requirements (nvim-lua#1477)
  don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)
  Replace vim.opt with vim.o (nvim-lua#1495)
  feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)
  Change to Mason's new address (nvim-lua#1516)
  feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
  Remove Telescope `0.1` branch lock (nvim-lua#1448)
  Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)
  fix: minor misspellings (nvim-lua#1450)
  feat(keymap): move windows without `<C-w>` (nvim-lua#1368)
  changed Conform's format_on_save lambda so that buffers that match disable_filetypes return nil. This allows you to enable a formatter for langages in the disable_filetypes table to have a formatter that can be run manually with Leader-f but doesnt enable format_on_save for them (nvim-lua#1395)
  fix: use correct github abmonition syntax (nvim-lua#1414)
  feat: add `vim.opt.confirm = true` (nvim-lua#1384)
CLEMENTINATOR pushed a commit to CLEMENTINATOR/nvim that referenced this pull request Jul 13, 2025
CLEMENTINATOR pushed a commit to CLEMENTINATOR/nvim that referenced this pull request Jul 13, 2025
louislouist pushed a commit to louislouist/kickstart-modular.nvim that referenced this pull request Jul 15, 2025
rexfordessilfie pushed a commit to rexfordessilfie/kickstart.nvim that referenced this pull request Jul 22, 2025
nico281 pushed a commit to nico281/kickstart-modular.nvim that referenced this pull request Jul 25, 2025
adityaravichandran6 added a commit to adityaravichandran6/mazov.nvim that referenced this pull request Aug 5, 2025
* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)

* Change to Mason's new address (nvim-lua#1516)

* feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)

* Replace vim.opt with vim.o (nvim-lua#1495)

* Replace vim.opt with vim.o

Because it offers a nicer interface and info on hover.
For now leave vim.opt when using the table interface (until vim.o
with tables is implemented)

* Add type hint for vim.opt.rtp

* Add a comment about using vim.opt instead of vim.o

* don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)

* README: mention fd-find in requirements (nvim-lua#1477)

Fixes nvim-lua#1476

* fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)

The functions of vim.highlight were renamed to vim.hl on commit
18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied
with the release of nvim version 0.11.

Now, the use of vim.highlight is deprecated, and instead, one should
use vim.hl functions.
In practice, vim.highlight is still working, however, asking for help
for vim.highlight.on_yank fails (E149), while asking for help for
vim.hl.on_yank works as expected. So, by updating the used function, a
new user will have easier time looking getting the relevant help.

Co-authored-by: Omri Sarig <[email protected]>

* Update remaining Mason's old address (nvim-lua#1530)

* Initial plugin setup (#1)

This adds a basic layer of plugins. But more language and workflow specific plugins are to follow possibly.

---------

Co-authored-by: dasvh <[email protected]>
Co-authored-by: Theo P. <[email protected]>
Co-authored-by: Dmytro Onypko <[email protected]>
Co-authored-by: Liam Dyer <[email protected]>
Co-authored-by: guru245 <[email protected]>
Co-authored-by: Ori Perry <[email protected]>
Co-authored-by: pynappo <[email protected]>
Co-authored-by: Damjan 9000 <[email protected]>
Co-authored-by: Omri Sarig <[email protected]>
Co-authored-by: Omri Sarig <[email protected]>
Co-authored-by: Carlos Calla Alarcón <[email protected]>
eduardofuncao pushed a commit to eduardofuncao/config.nvim that referenced this pull request Aug 5, 2025
adityaravichandran6 added a commit to adityaravichandran6/mazov.nvim that referenced this pull request Aug 7, 2025
* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)

* Change to Mason's new address (nvim-lua#1516)

* feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)

* Replace vim.opt with vim.o (nvim-lua#1495)

* Replace vim.opt with vim.o

Because it offers a nicer interface and info on hover.
For now leave vim.opt when using the table interface (until vim.o
with tables is implemented)

* Add type hint for vim.opt.rtp

* Add a comment about using vim.opt instead of vim.o

* don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)

* README: mention fd-find in requirements (nvim-lua#1477)

Fixes nvim-lua#1476

* fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)

The functions of vim.highlight were renamed to vim.hl on commit
18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied
with the release of nvim version 0.11.

Now, the use of vim.highlight is deprecated, and instead, one should
use vim.hl functions.
In practice, vim.highlight is still working, however, asking for help
for vim.highlight.on_yank fails (E149), while asking for help for
vim.hl.on_yank works as expected. So, by updating the used function, a
new user will have easier time looking getting the relevant help.

Co-authored-by: Omri Sarig <[email protected]>

* Update remaining Mason's old address (nvim-lua#1530)

* Initial plugin setup (#1)

This adds a basic layer of plugins. But more language and workflow specific plugins are to follow possibly.

---------

Co-authored-by: dasvh <[email protected]>
Co-authored-by: Theo P. <[email protected]>
Co-authored-by: Dmytro Onypko <[email protected]>
Co-authored-by: Liam Dyer <[email protected]>
Co-authored-by: guru245 <[email protected]>
Co-authored-by: Ori Perry <[email protected]>
Co-authored-by: pynappo <[email protected]>
Co-authored-by: Damjan 9000 <[email protected]>
Co-authored-by: Omri Sarig <[email protected]>
Co-authored-by: Omri Sarig <[email protected]>
Co-authored-by: Carlos Calla Alarcón <[email protected]>
jonbiemond added a commit to jonbiemond/kickstart.nvim that referenced this pull request Aug 7, 2025
This reverts commit d350db2.
blink.comp doesn't work for me.
devloglogan pushed a commit to devloglogan/kickstart.nvim that referenced this pull request Aug 11, 2025
alex-rieger pushed a commit to alex-rieger/kickstart.nvim that referenced this pull request Aug 17, 2025
k7o pushed a commit to k7o/kickstart.nvim that referenced this pull request Aug 18, 2025
benfleuty pushed a commit to benfleuty/kickstart.nvim that referenced this pull request Aug 19, 2025
LoganSchmalz pushed a commit to LoganSchmalz/kickstart.nvim that referenced this pull request Aug 21, 2025
ncason pushed a commit to ncason/kickstart.nvim that referenced this pull request Aug 23, 2025
nrhooks17 pushed a commit to nrhooks17/central-nvim that referenced this pull request Aug 26, 2025
sooren-ghodsi pushed a commit to sooren-ghodsi/kickstart.nvim that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use blink.cmp over nvim-cmp?
5 participants