-
Notifications
You must be signed in to change notification settings - Fork 38.8k
feat: switch nvim-cmp for blink.cmp #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested and works fine. Although before nvim-cmp, it shows the documentations. Maybe we need to enable for blink.cmp as well. opts = {
completion = {
-- Show documentation when available, with a small delay.
-- If you're noticing high CPU usage or stuttering when opening the
-- documentation, you may try setting
-- `completion.documentation.treesitter_highlighting = false`.
documentation = {
auto_show = true,
auto_show_delay_ms = 200,
},
},
} UPDATE: don't know if it is my system, but couldn't trigger show/hide documents with default keymaps. ( |
What's the status on this? :) |
fwiw, I have been using a version of this PR for over a week, and experienced no issues :D |
I've left this off by default but included a section about turning it on. This matches the behavior of built in completions and other major editors (i.e. vscode). I personally prefer the |
This looks brilliant. Not sure how to evaluate this versus the 'default completion' PR. I know I personally would rather see new users have this experience but I haven't honestly tried the default yet so I'll go test and and report back, and see if we can't get this resolved with a modicum of screaming :) Thank you! |
This is so very slightly slower than the 'native' completions as shown in the PR from @cmdrrobin . However I personally favor the vastly increased flexibility available with different providers and the like. Thus far I've seen way more strenuous opinions around a desire for the native completions support so I'm feeling rather like King Solomon at the moment :) |
What the hell, sounds like I have some work for the weekend :) Which LSP? |
basedpyright. This is just my perception and I didn't do any formal benchmarking. I'm not sure HOW I'd benchmark the two actually. I should look into that :) |
@feoh to be honest, I don't think it is worth the benchmark the two actually. ;-) |
You know what? I've seen several votes in favor of this PR and we don't have anyone who can support the 'native' version, so with thanks to @cmdrrobin and @Saghen for their hard work and participation I'm merging this. Great work all! |
* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
This reverts commit d350db2.
* master: Update remaining Mason's old address (nvim-lua#1530) fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482) README: mention fd-find in requirements (nvim-lua#1477) don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489) Replace vim.opt with vim.o (nvim-lua#1495) feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512) Change to Mason's new address (nvim-lua#1516) feat: switch nvim-cmp for blink.cmp (nvim-lua#1426) Remove Telescope `0.1` branch lock (nvim-lua#1448) Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427) fix: minor misspellings (nvim-lua#1450) feat(keymap): move windows without `<C-w>` (nvim-lua#1368) changed Conform's format_on_save lambda so that buffers that match disable_filetypes return nil. This allows you to enable a formatter for langages in the disable_filetypes table to have a formatter that can be run manually with Leader-f but doesnt enable format_on_save for them (nvim-lua#1395) fix: use correct github abmonition syntax (nvim-lua#1414) feat: add `vim.opt.confirm = true` (nvim-lua#1384)
* fix: minor misspellings (nvim-lua#1450) * fix: minor misspellings * revert change for `-Bbuild` * Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427) * refactor: change LSP keybindings to the default gr bindings introduced in 0.11 * refactor: modify existing LSP functions to follow convention * Remove Telescope `0.1` branch lock (nvim-lua#1448) * feat: switch nvim-cmp for blink.cmp (nvim-lua#1426) * Change to Mason's new address (nvim-lua#1516) * feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512) * Replace vim.opt with vim.o (nvim-lua#1495) * Replace vim.opt with vim.o Because it offers a nicer interface and info on hover. For now leave vim.opt when using the table interface (until vim.o with tables is implemented) * Add type hint for vim.opt.rtp * Add a comment about using vim.opt instead of vim.o * don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489) * README: mention fd-find in requirements (nvim-lua#1477) Fixes nvim-lua#1476 * fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482) The functions of vim.highlight were renamed to vim.hl on commit 18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied with the release of nvim version 0.11. Now, the use of vim.highlight is deprecated, and instead, one should use vim.hl functions. In practice, vim.highlight is still working, however, asking for help for vim.highlight.on_yank fails (E149), while asking for help for vim.hl.on_yank works as expected. So, by updating the used function, a new user will have easier time looking getting the relevant help. Co-authored-by: Omri Sarig <[email protected]> * Update remaining Mason's old address (nvim-lua#1530) * Initial plugin setup (#1) This adds a basic layer of plugins. But more language and workflow specific plugins are to follow possibly. --------- Co-authored-by: dasvh <[email protected]> Co-authored-by: Theo P. <[email protected]> Co-authored-by: Dmytro Onypko <[email protected]> Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: guru245 <[email protected]> Co-authored-by: Ori Perry <[email protected]> Co-authored-by: pynappo <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Omri Sarig <[email protected]> Co-authored-by: Omri Sarig <[email protected]> Co-authored-by: Carlos Calla Alarcón <[email protected]>
* fix: minor misspellings (nvim-lua#1450) * fix: minor misspellings * revert change for `-Bbuild` * Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427) * refactor: change LSP keybindings to the default gr bindings introduced in 0.11 * refactor: modify existing LSP functions to follow convention * Remove Telescope `0.1` branch lock (nvim-lua#1448) * feat: switch nvim-cmp for blink.cmp (nvim-lua#1426) * Change to Mason's new address (nvim-lua#1516) * feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512) * Replace vim.opt with vim.o (nvim-lua#1495) * Replace vim.opt with vim.o Because it offers a nicer interface and info on hover. For now leave vim.opt when using the table interface (until vim.o with tables is implemented) * Add type hint for vim.opt.rtp * Add a comment about using vim.opt instead of vim.o * don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489) * README: mention fd-find in requirements (nvim-lua#1477) Fixes nvim-lua#1476 * fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482) The functions of vim.highlight were renamed to vim.hl on commit 18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied with the release of nvim version 0.11. Now, the use of vim.highlight is deprecated, and instead, one should use vim.hl functions. In practice, vim.highlight is still working, however, asking for help for vim.highlight.on_yank fails (E149), while asking for help for vim.hl.on_yank works as expected. So, by updating the used function, a new user will have easier time looking getting the relevant help. Co-authored-by: Omri Sarig <[email protected]> * Update remaining Mason's old address (nvim-lua#1530) * Initial plugin setup (#1) This adds a basic layer of plugins. But more language and workflow specific plugins are to follow possibly. --------- Co-authored-by: dasvh <[email protected]> Co-authored-by: Theo P. <[email protected]> Co-authored-by: Dmytro Onypko <[email protected]> Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: guru245 <[email protected]> Co-authored-by: Ori Perry <[email protected]> Co-authored-by: pynappo <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Omri Sarig <[email protected]> Co-authored-by: Omri Sarig <[email protected]> Co-authored-by: Carlos Calla Alarcón <[email protected]>
This reverts commit d350db2. blink.comp doesn't work for me.
Opening as draft since I have yet to verify everything works as expected
Closes #1331