Skip to content

Create symbols.dic for Amharic language #18603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Million-ayenew
Copy link
Contributor

Amharic is a language that has it's own unique alphabets, numerals and punctuation marks. This list contains symbols used in it.

Link to issue number:

Summary of the issue:

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Amharic is a language that has it's own unique alphabets, numerals and punctuation marks. This list contains symbols used in it.
@Million-ayenew Million-ayenew requested a review from a team as a code owner August 1, 2025 23:27
@Million-ayenew Million-ayenew marked this pull request as draft August 1, 2025 23:37
@Million-ayenew
Copy link
Contributor Author

I will rewrite and try again.

@SaschaCowley
Copy link
Member

@Million-ayenew if you are using the GitHub website to create the file, once you are editing the new file, you need to change the indent mode to tabs. From the code editor, press NVDA+space to switch to browse mode, then press shift+c 3 times to get to the "Indent mode" combo box. Press enter to activate it, then press downArrow to select "Tabs". You can then press NVDA+space to switch to browse mode, then e to get back to the code editor, and enter to focus it in focus mode. The tab key should then insert the tab character, rather than spaces.

seanbudd added a commit that referenced this pull request Aug 4, 2025
…g on github (#18605)

Link to issue number:

Original discussion #18603 (comment)
Summary of the issue:

Tabs for indentation are needed when editing .dic files.
GitHub's code editor by default uses spaces when hitting the tab key.
You can change this from the code editor when editing a file.
Description of user facing changes:

Fix up docs
@Million-ayenew
Copy link
Contributor Author

Million-ayenew commented Aug 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants