Added reportHighlight to _reportFormattingHelper #15076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15075
Summary of the issue:
Highlight has not been reported when querying formatting manually via script in globalCommands, particularly useful after pr #14610.
Description of user facing changes
If a text is highlighted in Word, now it's reported with NVDA+f, even if highlight reporting is disabled in document formatting settings.
Description of development approach
Simply added "reportHighlight" as config key to query in _reportFormattingHelper, inside globalCommans.py.
Testing strategy:
Manual, for example with #5866 attachment.
Known issues with pull request:
It not covers highlight in web browsers via mark HTML tag, that seems exposed in another way/not in FormatField values.
Change log entries:
New features
Code Review Checklist: