Skip to content

Added reportHighlight to _reportFormattingHelper #15076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ABuffEr
Copy link
Contributor

@ABuffEr ABuffEr commented Jun 29, 2023

Link to issue number:

Fixes #15075

Summary of the issue:

Highlight has not been reported when querying formatting manually via script in globalCommands, particularly useful after pr #14610.

Description of user facing changes

If a text is highlighted in Word, now it's reported with NVDA+f, even if highlight reporting is disabled in document formatting settings.

Description of development approach

Simply added "reportHighlight" as config key to query in _reportFormattingHelper, inside globalCommans.py.

Testing strategy:

Manual, for example with #5866 attachment.

Known issues with pull request:

It not covers highlight in web browsers via mark HTML tag, that seems exposed in another way/not in FormatField values.

Change log entries:

New features

  • in Word without UIA, highlighting is now reported when user asks for formatting information.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@ABuffEr ABuffEr requested a review from a team as a code owner June 29, 2023 14:21
@ABuffEr ABuffEr requested a review from seanbudd June 29, 2023 14:21
@seanbudd
Copy link
Member

seanbudd commented Jun 30, 2023

Hi - as #14610 is unreleased - I am not going to add a changelog item.

@seanbudd seanbudd merged commit 4dce2ce into nvaccess:master Jun 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 30, 2023
@seanbudd
Copy link
Member

Thanks @ABuffEr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting report not include highlight
3 participants