Always re-enable audio ducking when starting a new utterance (#17770)

#17747. Does not fix it completely, but makes it better.

Summary of the issue:
When audio ducking is set to always duck, starting Magnifier overrides the audio ducking behavior, until the user changes the NVDA setting again.

Description of user facing changes
NVDA will now change the audio ducking behavior back to "always duck" each time a new utterance is started.

Although Magnifier can still cancel audio ducking when it's started, NVDA will fix this next time it starts an utterance.

Description of development approach
Made _setDuckingState(True) always executed regardless of the current ref count.

Author: gexgd0419

source/audioDucking.py

@@ -111,8 +111,9 @@ def _ensureDucked():
 		_duckingRefCount += 1
 		if _isDebug():
 			log.debug("Increased ref count, _duckingRefCount=%d" % _duckingRefCount)
-		if _duckingRefCount == 1 and _audioDuckingMode != AudioDuckingMode.NONE:
+		if _audioDuckingMode != AudioDuckingMode.NONE:
 			_setDuckingState(True)
+		if _duckingRefCount == 1 and _audioDuckingMode != AudioDuckingMode.NONE:
 			delta = 0
 		else:
 			delta = time.time() - _lastDuckedTime

user_docs/en/changes.md

@@ -129,6 +129,7 @@ In any document, if the cursor is on the last line, it will be moved to the end
 * The NVDA Highlighter Window icon is no longer fixed in the taskbar after restarting Explorer. (#17696, @hwf1324)
 * Fixed an issue where some SAPI4 voices (e.g. IBM TTS Chinese) cannot be loaded. (#17726, @gexgd0419)
 * In Excel, the element list dialog (`NVDA+f7`) no longer fails to list comment or formulas on some non-English systems. (#11366, @CyrilleB79)
+* NVDA can now restore the audio ducking behavior when speaking a new utterance, when another app such as Magnifier changes the behavior system-wide. (#17747, @gexgd0419)
 
 ### Changes for Developers