This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): tree-shake devtools from production bundle #6538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves nuxt/nuxt#14548
🔗 Linked issue
❓ Type of change
📚 Description
vue-router, uses new esm export conditions (dev, prod) which solved to remove devtools from production bundle in #5874 but other dependencies such asvue-i18n, with their bundler dist depend on special__VUE_PROD_DEVTOOLS__flag. This PR explicitly sets it to remove from final nitro bundle.Note: We still need to fix
@vue/devtools-apimock to avoid conditions it is leaked for any other reason.📝 Checklist