Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 2, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As a regression of nitrojs/nitro#166, we were generating dist/200/index.html instead of dist/200.html for spa fallbacks. This makes expected output.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 2, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit ef7e150
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62e9529fbc13cb00094f4216

@pi0 pi0 changed the title fix(nuxt): properly generate 200.html and 404.html fallback files fix(nuxt): generate 200.html and 404.html spa fallback files Aug 2, 2022
@pi0 pi0 merged commit 000d81d into main Aug 2, 2022
@pi0 pi0 deleted the fix/spa-fallback2 branch August 2, 2022 16:45
@TheAlexLichter
Copy link
Member

This still works only for ssr: false, right?

@pi0
Copy link
Member Author

pi0 commented Aug 2, 2022

@manniL Yes πŸ‘ We need nitro route rules as discussed to to selectively set spa mode on these routes when generating with ssr enabled.

@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants