Skip to content

Conversation

g1eny0ung
Copy link
Contributor

@g1eny0ung g1eny0ung commented May 26, 2023

πŸ”— Linked issue

Close #784

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add @type {boolean | typeof import('extract-css-chunks-webpack-plugin').PluginOptions} in JSDoc and then unbuild will generate the correct type.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix: supplement extractcss type fix: use correct extractCSS type May 31, 2023
@danielroe danielroe merged commit 137a3c0 into nuxt:main May 31, 2023
@g1eny0ung g1eny0ung deleted the fix/supplement-extractcss-type branch June 1, 2023 00:50
@wattanx wattanx mentioned this pull request Jun 3, 2023
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type declaration of build.extractCSS is wrong

2 participants