Skip to content

fix: throw error if defineNuxtConfig isn't used #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: throw error if defineNuxtConfig isn't used #405

merged 1 commit into from
Jul 13, 2022

Conversation

danielroe
Copy link
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We are performing normalization in defineNuxtConfig (e.g. #397) and if users don't use it Bridge won't work as expected.

@danielroe danielroe requested a review from pi0 July 13, 2022 10:02
@danielroe danielroe merged commit 686e3a9 into main Jul 13, 2022
@danielroe danielroe deleted the fix/require-wrapper branch July 13, 2022 10:12
@danielroe danielroe changed the title fix: throw error if wrapper isn't used fix: throw error if defineNuxtConfig isn't used Jul 13, 2022
@danielroe danielroe mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe @pi0