Skip to content

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Dec 21, 2021

  • Avoid mentioning "Nuxt 3" in docs
  • Allow bridge usage support as I couldn't any special feature not being supported
  • Avoid building commonJS version as @nuxt/kit is ESM-only
  • Enable CJS bridge to allow using __dirname
  • Move runtime (plugin, composables) to runtime/ dir and ensure is transpiled
  • Explicitly add all used dependencies. (Anything you do import should be in dependencies!)
  • Only bypass known options to runtime config
  • Read env in defaults
  • Remove additional type refs. defineNuxtModule sets them for setup

Note: We probably need another iteration of improvements once module builder is available but it at least prepares module for this step.

README.md Outdated
[![License][license-src]][license-href]

> [Strapi](https://strapi.io) module for [Nuxt 3](https://v3.nuxtjs.org)
> [Strapi](https://strapi.io) module for [Nuxt](https://v3.nuxtjs.org)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not mentioning Nuxt 3?

@benjamincanac benjamincanac merged commit bceac81 into dev Dec 22, 2021
@benjamincanac benjamincanac deleted the feat/module-improvements branch December 22, 2021 10:34
@pi0
Copy link
Contributor Author

pi0 commented Dec 22, 2021

We are not planning to fragment the ecosystem by introducing Nuxt3 branded modules! This is counter-effort at least not acceptable for modules being hosted in nuxt-community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants