Skip to content

Conversation

@Barbapapazes
Copy link
Contributor

@Barbapapazes Barbapapazes commented Feb 2, 2024

Hello,

I move this module to a fork of plausible-tracker to take back control of development. If I do correctly my job, there is no breaking change.

fix #5

@Barbapapazes Barbapapazes changed the title feat!: move to fork of plausible-analytics feat: move to fork of plausible-analytics Feb 2, 2024
@Barbapapazes
Copy link
Contributor Author

For the next major version, we could simplify options.

@johannschopplich
Copy link
Collaborator

Lovely! Will take a deeper look into it later. Thanks in advance. 🙂

@Barbapapazes
Copy link
Contributor Author

Maybe we should update the compatibility to 3.10 since I use the dependsOn for plugins (nuxt/nuxt#25409)

@johannschopplich
Copy link
Collaborator

johannschopplich commented Feb 3, 2024

As much as I like dependsOn, I don't think this breaking change is worth it. I know a handful of clients who haven't upgraded to newer Nuxt versions yet. I would much prefer providing users with your Plausible tracker fork than requiring them to upgrade to the latest Nuxt version as well. What do you think?

Can't we just use one plugin file and await import the functions, which are a separate plugin at the moment? Is the build chunk worth it?

Maybe migrate to dependsOn usage when it got more mainstream...

Having said that, maybe enforcing Nuxt 3.10 is OK. I haven't made up my mind yet. 😄 Your plugin split is much appreciated tho.

@Barbapapazes
Copy link
Contributor Author

As much as I like dependsOn, I don't think this breaking change is worth it. I know a handful of clients who haven't upgraded to newer Nuxt versions yet. I would much prefer providing users with your Plausible tracker fork than requiring them to upgrade to the latest Nuxt version as well. What do you think?

Can't we just use one plugin file and await import the functions, which are a separate plugin at the moment? Is the build chunk worth it?

Maybe migrate to dependsOn usage when it got more mainstream...

Having said that, maybe enforcing Nuxt 3.10 is OK. I haven't made up my mind yet. 😄 Your plugin split is much appreciated tho.

Will investigate but maybe, the dependsOn is useful when you depend on plugins from another module. Since it's an array, the order may be sufficient to initialize extensions after the main one.

@Barbapapazes
Copy link
Contributor Author

Barbapapazes commented Feb 3, 2024

As written here, https://nuxt.com/docs/guide/directory-structure/plugins#using-composables, plugins are called sequentially. This means we have just to order them!

No more breaking change @johannschopplich and I revert nuxt update.

@johannschopplich
Copy link
Collaborator

Great job, thanks a lot!

Note:
As far as I understand it, we can upgrade Nuxt, but if we would have to tighten compatibility, we would have to define it in the module meta:

compatibility: {
  nuxt: '^3',
},

@johannschopplich johannschopplich changed the title feat: move to fork of plausible-analytics feat: move to fork of plausible-analytics Feb 5, 2024
@johannschopplich johannschopplich merged commit 86f0e35 into nuxt-modules:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enableAutoOutboundTracking breaks target="_blank"

2 participants