Skip to content

fix: only append new entry to optimizeDeps on vite:extendConfig #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: only append new entry to optimizeDeps on vite:extendConfig #111

merged 2 commits into from
Dec 15, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Dec 13, 2023 •
edited
Loading

nuxt/nuxt#24196 (comment)

While vitejs/vite#15337 fixes it on the upstream, I still think it's better for us to also do the check so it works for existing users

@antfu antfu mentioned this pull request Dec 13, 2023
Closed
@antfu antfu requested a review from farnabaz December 13, 2023 13:01
@farnabaz farnabaz merged commit 3e1b7c6 into main Dec 15, 2023
@antfu antfu deleted the fix/vite-extend-config branch December 15, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfu @farnabaz @danielroe