website: timetables: Re-fix deserialization of TA courses in share link #4226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix didn't work for courses with multiple lessons. Fix that case. Fixes #4171
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zwliew
force-pushed
the
dev/zhao/fix-4171-again
branch
from
2dc2225 to
5c19420
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4226 +/- ##
==========================================
- Coverage 54.52% 52.93% -1.59%
==========================================
Files 274 289 +15
Lines 6076 6685 +609
Branches 1455 1631 +176
==========================================
+ Hits 3313 3539 +226
- Misses 2763 3146 +383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The previous fix didn't work for courses with multiple lessons. Fix that case.
Fixes #4171 again
Implementation
Other Information