Skip to content

Conversation

@CharliePoole
Copy link
Member

Fixes #1570

@CharliePoole CharliePoole requested review from manfred-brands and stevenaw and removed request for manfred-brands February 23, 2025 17:13
Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CharliePoole No concerns from me.

Curious to hear your thoughts on if we should be issuing a warning or info of some kind if a user tries to "disable" an extension which couldn't be found. There would be no functional difference to the run either way, of course, but such a scenario could arise from a misconfiguration that a user may appreciate a notice about.

@CharliePoole
Copy link
Member Author

Thanks for reviewing @stevenaw .

I thought about a warning and didn't do it for several reasons.

  1. We don't do warnings very well unless they pertain to individual tests. In that case we give a WARNING result. But general warnings can only be displayed in the output as text, probably at the start of the run.
  2. Giving a warning doesn't work very nicely with the use case where the test may be run on various machines with or without the extension and you want the result to be the same on all machines.

So, I decided to leave it out on the principle that someone with a use case where a warning would really be helpful can always ask for a change.

@CharliePoole CharliePoole merged commit e9a52df into main Feb 27, 2025
4 checks passed
@CharliePoole CharliePoole deleted the issue-1570 branch February 27, 2025 22:23
@stevenaw
Copy link
Member

That makes a lot of sense. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Presence of a TEAMCITY_PROJECT_NAME environment variable makes builds fail if TeamCity service unavailable

3 participants