Add .NET 8 build for nunit-agent

[mlessmann]

We are currently migrating to .NET 8 and are having trouble executing NUnit 3.13 tests with the NUnit Console 3.16.3. There are some errors at test runtime that occur because the test is run on the .NET 7 build of nunit-agent. Specifically, the test depends on a particular version of a DLL that is only present in .NET 8.

Would it be possible to create a .NET 8 build of the nunit-agent?

I have already created branches from main and from the 3.16.3 tag and changed code and project files. I haven't touched the pipelines.

[ilCosmico]

After updating my UnitTesting project from .NET6/.NET7 to .NET8 I get the following errors.

Is this the same issue as yours?

I'm using NUnit 3.13.3 and console runner 3.16.3 too.

[mlessmann]

They were different assemblies (not WinForms), but otherwise I had the same errors.

[OsirisTerje]

Can you please try to run version 3.15.5 instead.

[mlessmann]

Using 3.15.5 leads to the same error messages:

Unable to load one or more of the requested types.
Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

[ilCosmico]

I confirm I get the same System.Runtime error when using 3.15.5.

[OsirisTerje]

Thanks @ilCosmico and @mlessmann .

I am on travel now, and have small opportunities to do changes myself. I can review, merge and get stuff out if you provide the code for this.

The engine should be good for .net 8, that was done some time ago, and works for the adapter. So there is then the console app that remains.

@mlessmann It seems you have found the reasons, and also, providing an agent for .net 8 should be trivial. But, need you to do the changes on the version315 branch.

The process for the console/engine release is not trivial however, but having the code in there in a PR would certainly make it easier for us to get it out.

I've created a milestone 3.17 for this issue. The branch name will remain version315 until I can get these sorted out.

PS: I assume you guys now that using dotnet test with the NUnit3Testadapter works for .net8? If you can use that instead of the console you should be unblocked. I know there might be reasons for using the console, so we want to have this fixed too.

[mlessmann]

I have created a PR that adds .NET 8 builds for the console and the agent. My .NET 8 tests run successfully with this version locally.
I have tried to adjust the cake scripts, but I'm unfamiliar with them and would appreciate feedback.

#1378

[OsirisTerje]

The scripts look ok to me. I'll try to use them "as is", and we see how it goes.

[OsirisTerje]

@mlessmann Did you get a series of errors like this one:

C:\repos\nunit\nunit-console\src\NUnitEngine\nunit.engine.tests\nunit.engine.tests.csproj : error NU1902: Warning As Er
ror: Package 'Microsoft.NETCore.App' 2.1.0 has a known moderate severity vulnerability, https://github.com/advisories/G
HSA-vgwq-hfqc-58wv [C:\repos\nunit\nunit-console\NUnitConsole.sln]

[mlessmann]

@OsirisTerje Yes. That's why I added these entries to the affected csproj files:
<NuGetAudit Condition="'$(TargetFramework)'=='netcoreapp2.1'">false</NuGetAudit>
Unfortunately, the condition only seems to work in Visual Studio. I've created #1379 to fix this.

[ilCosmico]

@mlessmann thanks for the great job!
@OsirisTerje so do we need to wait for 3.17 to be able running .NET8 unit testing?