-
Notifications
You must be signed in to change notification settings - Fork 161
Updated release notes for NUnit 4.3 #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM so far, but not merging because the title still has WIP so I assume @OsirisTerje has it still in progress. |
|
@SeanKilleen @manfred-brands @stevenaw @mikkelbu I have changed the release notes to be different with respect to acknowledgements. Does it look ok to you? I have picked a bit from how @mikkelbu has been doing it, but keeping the individuals for each PR, but also added the individual team members who contributed. (In Norway, we often overlook the individual when celebrating the achievements of the team :-) Trying to improve on that. ) And yes, the notes have been code generated using the github api :-) |
mikkelbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. I only have some nit-pick, questions, and 3 instances of markdown generating Thanks to for PR... (so no mention of the contributor)
manfred-brands
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it to. Nothing to add to @mikkelbu review comments,
Co-authored-by: Mikkel Nylander Bundgaard <[email protected]>
Updated release notes for NUnit 4.3 1aac5ed
No description provided.