Skip to content

Conversation

@OsirisTerje
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 1, 2024

@SeanKilleen
Copy link
Member

LGTM so far, but not merging because the title still has WIP so I assume @OsirisTerje has it still in progress.

@OsirisTerje
Copy link
Member Author

OsirisTerje commented Dec 1, 2024

@SeanKilleen @manfred-brands @stevenaw @mikkelbu

I have changed the release notes to be different with respect to acknowledgements. Does it look ok to you?

I have picked a bit from how @mikkelbu has been doing it, but keeping the individuals for each PR, but also added the individual team members who contributed. (In Norway, we often overlook the individual when celebrating the achievements of the team :-) Trying to improve on that. )

And yes, the notes have been code generated using the github api :-)

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I only have some nit-pick, questions, and 3 instances of markdown generating Thanks to for PR... (so no mention of the contributor)

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it to. Nothing to add to @mikkelbu review comments,

@OsirisTerje OsirisTerje changed the title WIP: Updated release notes for NUnit 4.3 Updated release notes for NUnit 4.3 Dec 14, 2024
@OsirisTerje OsirisTerje merged commit 1aac5ed into master Dec 14, 2024
7 checks passed
@OsirisTerje OsirisTerje deleted the nunit4.3 branch December 14, 2024 19:07
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
Updated release notes for NUnit 4.3 1aac5ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants