New API Spec #54
Open
New API Spec #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-villalba
changed the title
…we will need to address at some point
…sense. Also expanded the amount of configuration options available by using podSpec
rytswd
reviewed
Oct 26, 2025
Comment on lines
+73
to
+88
| // StatelessSpec defines the desired state for a scalable, stateless component | ||
| // like MultiAdmin, MultiOrch, or MultiGateway. | ||
| type StatelessSpec struct { | ||
| // Replicas is the desired number of pods. | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +optional | ||
| Replicas *int32 `json:"replicas,omitempty"` | ||
|
|
||
| // Affinity defines the pod's scheduling constraints. | ||
| // +optional | ||
| Affinity *corev1.Affinity `json:"affinity,omitempty"` | ||
|
|
||
| // Resources defines the compute resource requirements. | ||
| // +optional | ||
| corev1.ResourceRequirements `json:"resources,omitempty"` | ||
| } |
There was a problem hiding this comment.
Because this is used by multiple resources, let's move this to a separate file
There was a problem hiding this comment.
Can you please remove all the code from internal/controller, as we will not be using them (and they are basically useless templates as is).
There was a problem hiding this comment.
I think this was meant to be renamed to "tablegroup_types.go"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API spec is now ready to review. You can use this design as reference to check the API definition:
https://github.com/numtide/multigres-operator/blob/multigres-cluster-cr-design/plans/phase-1/final-cr-definition.md
Please note that the pipeline failed due to the KubeBuilder generated controller files, which we could remove if needed, or use as a reference to code forward.