Build system: Improve portability, parallelization, and VPATH builds #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanNardi
force-pushed
the
build-system-improvements
branch
2 times, most recently
from
852da1d to
f597ca8
Compare
This commit implements comprehensive improvements to the nDPI build system to enhance portability, enable parallel testing, and ensure reliable out-of-tree (VPATH) builds across all platforms. Changes: 1. Optimize library linking order (configure.ac, all Makefiles) - Reorder ADDITIONAL_LIBS to follow proper dependency hierarchy - Move low-level libraries (libm) to end of link line - Ensures compatibility with --as-needed linker flag - Improves LTO and static linking support 2. Fix VPATH build dependencies (all Makefiles) - Add explicit dependencies on generated headers (ndpi_config.h, ndpi_define.h) - Prevents race conditions in parallel builds (make -j) - Ensures headers exist before compilation starts 3. Replace mkdir -p with portable $(MKDIR_P) macro 4. Enable parallel test execution (configure.ac) - Add 'parallel-tests' option to AM_INIT_AUTOMAKE - Allows test suites to run concurrently during 'make check' 5. Add defensive .NOTPARALLEL directive (Makefile.am) - Prevents race conditions if 'make -j clean distclean' is run 6. Fix clean target completeness (src/lib/Makefile.in) - Remove all .so symlinks (libndpi.so, libndpi.so.N) - Add cleanup for Windows DLL files (*.dll) - Explicitly remove versioned shared libraries 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Ivan Nardi <[email protected]>
IvanNardi
force-pushed
the
build-system-improvements
branch
from
f597ca8 to
16e65d5
Compare
Ensure that performance test tools are compiled with project warning flags (NDPI_CFLAGS) for consistent code quality standards across the codebase. Previously, tests/performance/Makefile.in compiled tools (gcrypt-int, gcrypt-gnu, substringsearch, strnstr, geo, patriciasearch) with only user-provided CFLAGS, missing the project's warning flags (-W, -Wall, -Wno-address-of-packed-member). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements comprehensive improvements to the nDPI build system to enhance portability, enable parallel testing, and ensure reliable out-of-tree (VPATH) builds across all platforms.
Changes:
Optimize library linking order (configure.ac, all Makefiles)
Fix VPATH build dependencies (all Makefiles)
Replace mkdir -p with portable $(MKDIR_P) macro
Enable parallel test execution (configure.ac)
Add defensive .NOTPARALLEL directive (Makefile.am)
Fix clean target completeness (src/lib/Makefile.in)
🤖 Generated with Claude Code