Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a potential Server-Side Request Forgery (SSRF) vulnerability in the
EditDomainForm.clean()
method.Details
Currently, the form accepts arbitrary
nameserver_ip
inputs, which are passed to thecheck_domain()
function. This leads to dynamic DNS update attempts to the specified IP address, including internal ones (e.g., 127.0.0.1). As a result, attackers could potentially:Fix
This patch adds validation using Python’s
ipaddress
module to reject loopback, private, and reserved IP addresses before performing any DNS update.Impact
This prevents misuse of the DNS update mechanism and mitigates the risk of SSRF attacks via internal IP injection.