Skip to content

Conversation

brad
Copy link
Contributor

@brad brad commented Jan 12, 2024

The current version of Jekyll has security vulnerabilities reported by Snyk.io. This PR fixes them with an upgrade to Jekyll

Before

image

After

image

I rebuilt the docs to make sure it didn't break anything and it builds fine, except I couldn't build until I added kramdown-parser-gfm to the Gemfile
image

@alexandrnikitin
Copy link
Member

That's great! Thank you so much! We wanted to update the docs dependencies for a long time.

What ruby version did you use? We use 2.5 but maybe it's worth to update it too.

- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.5'
bundler-cache: true

@brad
Copy link
Contributor Author

brad commented Jan 13, 2024

@alexandrnikitin No problem! I used Ruby 2.7.7, I've made the update to build_and_test.yml. I hope that will do it

@alexandrnikitin alexandrnikitin merged commit 83abbcd into nsubstitute:main Jan 28, 2024
@brad brad deleted the feature/upgrade-jekyll branch January 29, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants