fix(core): ensure that global nx works with dot-nx workspace after init #31249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 2193af4.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
May 16, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
May 16, 2025
…it (#31249) This PR fixes an issue with the global `nx` command, where running `nx init` in a non-JS folder (i.e. using dot-nx setup) results in a workspace that doesn't work with the global command. e.g. ``` brew install nx cd some-java-project nx init nx report ``` https://www.loom.com/share/e8dbb2fb7a084300a4dd1e5dff2c0db1 ## Current Behavior `nx report` or any other command fails ## Expected Behavior `nx` commands should work ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 840f5f4)
FrozenPandaz
pushed a commit
that referenced
this pull request
May 16, 2025
…it (#31249) This PR fixes an issue with the global `nx` command, where running `nx init` in a non-JS folder (i.e. using dot-nx setup) results in a workspace that doesn't work with the global command. e.g. ``` brew install nx cd some-java-project nx init nx report ``` https://www.loom.com/share/e8dbb2fb7a084300a4dd1e5dff2c0db1 ## Current Behavior `nx report` or any other command fails ## Expected Behavior `nx` commands should work ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 840f5f4)
|
@jaysoo random question 😅 why does your change fix this? Does running the local version of NX like this perform some side-effect that then makes the global version work properly? |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the global
nxcommand, where runningnx initin a non-JS folder (i.e. using dot-nx setup) results in a workspace that doesn't work with the global command.e.g.
https://www.loom.com/share/e8dbb2fb7a084300a4dd1e5dff2c0db1
Current Behavior
nx reportor any other command failsExpected Behavior
nxcommands should workRelated Issue(s)
Fixes #