Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Conversation

@irega
Copy link

@irega irega commented Jul 17, 2019

Bumps node-gyp from ^5.0.2 to ^5.0.3 as requested in this nodejs PR

@irega irega marked this pull request as ready for review July 17, 2019 15:54
@irega
Copy link
Author

irega commented Jul 19, 2019

@isaacs sorry I see now that there is not any reviewer sorry xD Can you approve the PR?

@isaacs
Copy link
Contributor

isaacs commented Jul 19, 2019

I've already got node-gyp 5.0.3 slated for inclusion in the npm cli 6.10.2 release. I can update the minimum requirement in npm-lifecycle as well, but it seems perhaps unnecessary since it would be pulled in by anyone doing an update anyway?

@irega
Copy link
Author

irega commented Jul 19, 2019

I've already got node-gyp 5.0.3 slated for inclusion in the npm cli 6.10.2 release. I can update the minimum requirement in npm-lifecycle as well, but it seems perhaps unnecessary since it would be pulled in by anyone doing an update anyway?

Sorry I did not see your commit on the 6.10.2 release, I close this PR ;)

@irega irega closed this Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants