Skip to content

fix: gracefully fallback from auth-type=web #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: gracefully fallback from auth-type=web #6158

merged 2 commits into from
Feb 14, 2023
+126 −20

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Feb 10, 2023

Originally auth-type=web would gracefully fallback to auth-type=legacy if a registry had not yet implemented web. This brings back that behavior.

@MylesBorins MylesBorins requested a review from a team as a code owner February 10, 2023 20:40
@MylesBorins MylesBorins requested review from nlf and removed request for a team February 10, 2023 20:40
@MylesBorins MylesBorins force-pushed the graceful-auth-type branch 2 times, most recently from 763f525 to 110d753 Compare February 10, 2023 20:45
@MylesBorins MylesBorins mentioned this pull request Feb 10, 2023
Closed
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Feb 10, 2023 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.412 ±2.57 18.148 ±0.12 16.587 ±0.05 19.094 ±0.73 3.035 ±0.06 3.010 ±0.00 2.381 ±0.02 11.574 ±0.04 2.408 ±0.04 3.576 ±0.11
#6158 38.084 ±2.70 17.827 ±0.06 16.562 ±0.05 19.341 ±0.87 3.041 ±0.01 3.004 ±0.01 2.348 ±0.00 11.630 ±0.05 2.351 ±0.01 3.834 ±0.55
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 25.462 ±1.48 14.103 ±0.06 12.867 ±0.02 13.778 ±0.05 2.711 ±0.03 2.733 ±0.04 2.437 ±0.04 8.846 ±0.00 2.270 ±0.01 3.187 ±0.05
#6158 26.328 ±2.33 14.444 ±0.45 12.979 ±0.03 13.827 ±0.22 2.758 ±0.03 2.809 ±0.08 2.332 ±0.01 8.919 ±0.03 2.210 ±0.05 3.181 ±0.01

@Ibrahim11a

This comment was marked as spam.

Sign in to view
@MylesBorins
fix: gracefully fallback from auth-type=web
3731031 
Originally `auth-type=web` would gracefully fallback to
`auth-type=legacy` if a registry had not yet implemented
web. This brings back that behavior.
@wraithgar wraithgar changed the title auth-type: gracefully fallback from web fix: gracefully fallback from auth-type=web Feb 13, 2023
@MylesBorins MylesBorins mentioned this pull request Feb 14, 2023
Merged
@wraithgar wraithgar merged commit 53f75a4 into latest Feb 14, 2023
@wraithgar wraithgar deleted the graceful-auth-type branch February 14, 2023 16:56
@npm-cli-bot npm-cli-bot mentioned this pull request Feb 15, 2023
Merged
@juanpicado juanpicado mentioned this pull request Apr 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlf nlf Awaiting requested review from nlf nlf is a code owner automatically assigned from npm/cli-team

1 more reviewer

@lukekarrys lukekarrys lukekarrys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins @npm-cli-bot @Ibrahim11a @lukekarrys @wraithgar