Preserve collation when changing column type #3479
Merged
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR aims to preserve the collation when changing a column’s type.
- Updates the logic to always add an explicit COLLATE clause when a new collation is provided.
- Enhances the SQL generation to reset collation to a default when the type remains unchanged.
Reviewed Changes
| File | Description |
|---|---|
| src/EFCore.PG/Migrations/NpgsqlMigrationsSqlGenerator.cs | Adjusts COLLATE clause logic during ALTER COLUMN operations. |
| test/EFCore.PG.FunctionalTests/Migrations/MigrationsNpgsqlTest.cs | Updates tests to validate the new collation preservation behavior. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/EFCore.PG.FunctionalTests/Migrations/MigrationsNpgsqlTest.cs:981
- The test currently verifies the non-default collation scenario; however, ensure there is corresponding coverage for the branch in which newCollation is null and the default collation is explicitly reset.
AssertSql(...
roji
added a commit
that referenced
this pull request
Feb 28, 2025
roji
added a commit
that referenced
this pull request
Feb 28, 2025
roji
added a commit
that referenced
this pull request
Feb 28, 2025
roji
added a commit
that referenced
this pull request
Feb 28, 2025
Member
Author
roji
added a commit
that referenced
this pull request
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3476