fixed tooltip position for charts placed on lower part of the page #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per issue novus#2163, fixed by @RedScourge. This will fix the tooltip position of charts placed on lower part of the page where scrolling is needed.
|
Any chance this gets merged? Currently all tooltips are positioned incorrectly if the page is not scrolled to the top. |
unfortunately, most (if not all) of the PR are falling the automated CI test, because of an error on an existing code not on the actual proposed changes. |
|
I'm not on this project anymore so I can't merge anything, the novus guys removed me. I created the nvd3/nvd3 repo though as a separate work to get it working with newer versions of D3. Feel free to help out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per issue #2163, fixed by @RedScourge. This will fix the tooltip position of charts placed on lower part of the page where scrolling is needed.