Fix modifier keys not being sent on Firefox #1963
Closed
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for modifier keys to be sent on Firefox, even if
privacy.resistFingerprinting
is enabled or not.Firefox does set the modifiers in the event itself but when
privacy.resistFingerprinting
is enabled it doesn't send them, therefore this code handles that issue and sends it manually allowing for key combos like Ctrl+Alt+Delete to work out of the box.I've tested this on Firefox and Librewolf with both
privacy.resistFingerprinting
enabled and disabled, both give the same intended result.This also fixes #1882