Add extended clipboard Pseudo-Encoding #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CendioOssman
requested changes
Feb 11, 2020
CendioNiko
force-pushed
the
clipboard_unicode
branch
2 times, most recently
from
5c14525 to
df3941c
Compare
|
Tested against Xvnc server with extended clipboard pseudo-encoding support on following:
Also tested against older Xvnc server that did not support extended clipboard pseudo-encoding on Fedora 30 in Firefox 69. |
Don't rely on clientCutText() to test clipboardPasteFrom().
CendioOssman
requested changes
Feb 17, 2020
samhed
requested changes
Feb 17, 2020
Wraps pako's deflate for easier usage.
Will be used in later commit in extended clipboard handling.
The value true was an invalid flush argument so it was in practice unused.
Every call wants this check so this should be done inside the class.
Added ability to read data chunk wise.
CendioNiko
force-pushed
the
clipboard_unicode
branch
2 times, most recently
from
df12343 to
f6cfba4
Compare
Add extended clipboard pseudo-encoding to allow the use of unicode characters in the clipboard.
CendioOssman
force-pushed
the
clipboard_unicode
branch
from
f6cfba4 to
f73fdc3
Compare
CendioOssman
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current clipboard did not support transferring Unicode characters. This pull request adds support for extended clipboard pseudo-encoding on the client. The server must also support extended clipboard pseoudo-encoding for this solution to take effect. The servers I know of use this protocol is TigerVNC and UltraVNC.
Fixes #61