Use "nomodule" instead of manual check #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very few browsers are left in the wild that supports modules but not "nomodule", so let's simplify our handling a bit. Safari 10 supports modules but not 'nomodule', this means that this particular version of Safari will be broken. Due to this we have to bump up the required Safari version to 11.
samhed
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Works well. Verified on IE 11, Edge, Chrome, Firefox on Windows 10 and Safari 14 on macOS 10.14.
Safari 10 supports modules but not 'nomodule', this means this particular version will be very broken. But it seems the market share for Safari 10 is quite small, so we're willing to live with this.
I force-pushed an update to the README in this commit that updates the minimum required safari version as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very few browsers are left in the wild that supports modules but not "nomodule", so let's simplify our handling a bit.
See here:
https://caniuse.com/#search=nomodule
It's basically Safari 10 (on both iOS and macOS) that is the issue, and there seems to be few devices out there still using it.