Skip to content

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented May 26, 2022

--pluginConfig flag is currently not being split by , when there are multiple entries.

This PR fixes the parsing of the --pluginConfig flag to correctly account for multiple entries.

Signed-off-by: qmuntal [email protected]

Signed-off-by: qmuntal <[email protected]>
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good

qmuntal and others added 2 commits May 28, 2022 09:16
Co-authored-by: Rakesh Gariganti <[email protected]>
Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@NiazFK NiazFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiazFK NiazFK merged commit 97a0d71 into notaryproject:main May 31, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
- Fix pluginConfig parsing
- improve quote handling
- trim white spaces and error on empty entry 
- take into account empty entries
- add missing test

Signed-off-by: qmuntal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants