Fix pluginConfig parsing #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qmuntal <[email protected]>
dtzar
approved these changes
May 26, 2022
gokarnm
reviewed
May 26, 2022
Signed-off-by: qmuntal <[email protected]>
rgnote
reviewed
May 26, 2022
4 tasks
Signed-off-by: qmuntal <[email protected]>
gokarnm
approved these changes
May 27, 2022
rgnote
reviewed
May 27, 2022
Signed-off-by: qmuntal <[email protected]>
Co-authored-by: Rakesh Gariganti <[email protected]> Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
- Fix pluginConfig parsing - improve quote handling - trim white spaces and error on empty entry - take into account empty entries - add missing test Signed-off-by: qmuntal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--pluginConfigflag is currently not being split by,when there are multiple entries.This PR fixes the parsing of the
--pluginConfigflag to correctly account for multiple entries.Signed-off-by: qmuntal [email protected]