-
Notifications
You must be signed in to change notification settings - Fork 87
Fix pluginConfig parsing #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good
Co-authored-by: Rakesh Gariganti <[email protected]> Signed-off-by: qmuntal <[email protected]>
Signed-off-by: qmuntal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Fix pluginConfig parsing - improve quote handling - trim white spaces and error on empty entry - take into account empty entries - add missing test Signed-off-by: qmuntal <[email protected]>
--pluginConfig
flag is currently not being split by,
when there are multiple entries.This PR fixes the parsing of the
--pluginConfig
flag to correctly account for multiple entries.Signed-off-by: qmuntal [email protected]