Allow modifying xmllint args and validate file names #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new optional option `modifyArguments`, which allows you to arbitrarily add or modify the command line arguments that are passed to the xmllint command. The option is a function that receives the current arguments as an array, and should return a new array of string arguments. Closes [#22](#22). Also adds validation that XML and Schema file names do not start with a dash (`-`), or contain a space and a dash (` -`), which would cause xmllint to interpret the file name as a command line option. File names could be user-inputted, so this change is to prevent end users from accidentally or maliciously changing the expected behaviour of the validation. It is recommended, though, to also do stricter validation of file names if you accept them from user input. This is a **breaking change** if you previously passed in file names that started with a dash. There is a new option `disableFileNameValidation` to disable this validation if you want to keep the old behaviour and accept any kind of file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new optional option
modifyArguments, which allows you to arbitrarily add or modify the command line arguments that are passed to the xmllint command. The option is a function that receives the current arguments as an array, and should return a new array of string arguments.Closes #22.
Also adds validation that XML and Schema file names do not start with a dash (
-), or contain a space and a dash (-), which would cause xmllint to interpret the file name as a command line option. File names could be user-inputted, so this change is to prevent end users from accidentally or maliciously changing the expected behaviour of the validation. It is recommended, though, to also do stricter validation of file names if you accept them from user input. This is a breaking change if you previously passed in file names that started with a dash. There is a new optiondisableFileNameValidationto disable this validation if you want to keep the old behaviour and accept any kind of file name.