webGPU pipelines #181
Draft
webGPU pipelines #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Merged
Draft
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+32
to
37
| throw new Error("Not implemented") | ||
| super(device, deeptable); | ||
| this.params = { ...defaultTinyForestParams, ...t }; | ||
| this.initializeForestsToZero(); | ||
| this.bufferSet = new WebGPUBufferSet(device, bufferSize); | ||
| } |
There was a problem hiding this comment.
The throw statement makes all code after it unreachable. Either move the throw to the end of the constructor if the intent is to prevent instantiation, or remove the unreachable code that follows it. Currently the bufferSet assignment and other initialization code will never execute.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Dec 20, 2024
bmschmidt
force-pushed
the
12-17-webgpu_resources
branch
from
1e1ae8e to
830811c
Compare
bmschmidt
force-pushed
the
12-18-webgpu_pipelines
branch
from
5670864 to
8548081
Compare
bmschmidt
force-pushed
the
12-17-webgpu_resources
branch
from
830811c to
a23a2c3
Compare
bmschmidt
force-pushed
the
12-18-webgpu_pipelines
branch
from
8548081 to
8b78ca4
Compare
bmschmidt
force-pushed
the
12-17-webgpu_resources
branch
from
a23a2c3 to
b9dc76b
Compare
bmschmidt
force-pushed
the
12-18-webgpu_pipelines
branch
from
8b78ca4 to
459e29b
Compare
bmschmidt
force-pushed
the
12-17-webgpu_resources
branch
from
b9dc76b to
83f360f
Compare
bmschmidt
force-pushed
the
12-18-webgpu_pipelines
branch
from
459e29b to
07fc8ff
Compare
bmschmidt
force-pushed
the
12-17-webgpu_resources
branch
from
83f360f to
07bc4b3
Compare
bmschmidt
force-pushed
the
12-18-webgpu_pipelines
branch
from
07fc8ff to
2eff59a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.