fix(core): add React as optional peer dependency to fix monorepo resolution #8079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds React and React DOM as optional peer dependencies to enable proper dependency resolution in monorepo environments with multiple React versions.
Why?
We had an issue when using the same version of
swiperin a monorepo with different React versions. When rendering server-side, we'd get a hook warning with the wrong version of React resolved.pnpmwasn't linking the correct version of React because it doesn't knowswiperdepends on it.In our project, I've used a bit of middleware in
.pnpmfile.cjsto addreact+react-domto the peer dependencies insideswiper. This has letpnpmknow that it needs to link the right version of React rather than just resolving the nearest version:(Our project's .pnpmfile.cjs)
Thought it might be useful for others so I thought I'd open this PR! 🙂