perf: remove <img>
's src
when offscreen
#449
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional optimization on top of #445 in order to address #444.
It turns out that browsers seem to do some extra work when a
src
is set on an<img>
, even if that image is offscreen, even if it's marked<img loading=lazy>
, and even if it's hidden withcontent-visibility: auto
. To fix that, you can simply use the olddata-src
trick and set thesrc
only when the<img>
is visible.To detect visibility, we can use the
contentvisibilityautostatechange
event (kind of like anIntersectionObserver
but a bit simpler).Oddly this event only seems to fire on the element itself and not bubble in Firefox only, but we can just set the event listener on the element itself to fix that.
Improvement in Chrome: 13-19%
Improvement in Firefox: 35-37%