chore!: remove verify_signature_slice methods from stdlib

compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs

@@ -243,15 +243,6 @@ fn blake_hash(
 ///   signature: [u8; 64],
 ///   message_hash: [u8; N],
 /// ) -> bool
-///
-/// pub fn verify_signature_slice(
-///   public_key_x: [u8; 32],
-///   public_key_y: [u8; 32],
-///   signature: [u8; 64],
-///   message_hash: [u8],
-/// ) -> bool
-/// ```
-///
 // cSpell:disable-next-line
 fn ecdsa_secp256_verify(
     interner: &mut NodeInterner,

docs/docs/noir/standard_library/cryptographic_primitives/ecdsa_sig_verification.mdx

@@ -12,7 +12,6 @@ Noir supports ECDSA signatures verification over the secp256k1 and secp256r1 cur
 ## ecdsa_secp256k1::verify_signature
 
 Verifier for ECDSA Secp256k1 signatures.
-See ecdsa_secp256k1::verify_signature_slice for a version that accepts slices directly.
 
 #include_code ecdsa_secp256k1 noir_stdlib/src/ecdsa_secp256k1.nr rust
 
@@ -27,20 +26,6 @@ fn main(hashed_message : [u8;32], pub_key_x : [u8;32], pub_key_y : [u8;32], sign
 
 <BlackBoxInfo to="../black_box_fns" />
 
-## ecdsa_secp256k1::verify_signature_slice
-
-:::info
-
-This method is deprecated and will be removed in 1.0.0-beta.12
-
-:::
-
-Verifier for ECDSA Secp256k1 signatures where the message is a slice.
-
-#include_code ecdsa_secp256k1_slice noir_stdlib/src/ecdsa_secp256k1.nr rust
-
-<BlackBoxInfo to="../black_box_fns"/>
-
 ## ecdsa_secp256r1::verify_signature
 
 Verifier for ECDSA Secp256r1 signatures.
@@ -58,17 +43,3 @@ fn main(hashed_message : [u8;32], pub_key_x : [u8;32], pub_key_y : [u8;32], sign
 ```
 
 <BlackBoxInfo to="../black_box_fns"/>
-
-## ecdsa_secp256r1::verify_signature
-
-:::info
-
-This method is deprecated and will be removed in 1.0.0-beta.12
-
-:::
-
-Verifier for ECDSA Secp256r1 signatures where the message is a slice.
-
-#include_code ecdsa_secp256r1_slice noir_stdlib/src/ecdsa_secp256r1.nr rust
-
-<BlackBoxInfo to="../black_box_fns"/>

noir_stdlib/src/ecdsa_secp256k1.nr

@@ -23,15 +23,3 @@ pub fn verify_signature<let N: u32>(
 ) -> bool
 // docs:end:ecdsa_secp256k1
 {}
-
-#[deprecated("This method is deprecated and will be removed in 1.0.0-beta.12")]
-#[foreign(ecdsa_secp256k1)]
-// docs:start:ecdsa_secp256k1_slice
-pub fn verify_signature_slice(
-    public_key_x: [u8; 32],
-    public_key_y: [u8; 32],
-    signature: [u8; 64],
-    message_hash: [u8],
-) -> bool
-// docs:end:ecdsa_secp256k1_slice
-{}

noir_stdlib/src/ecdsa_secp256r1.nr

@@ -8,15 +8,3 @@ pub fn verify_signature<let N: u32>(
 ) -> bool
 // docs:end:ecdsa_secp256r1
 {}
-
-#[deprecated("This method is deprecated and will be removed in 1.0.0-beta.12")]
-#[foreign(ecdsa_secp256r1)]
-// docs:start:ecdsa_secp256r1_slice
-pub fn verify_signature_slice(
-    public_key_x: [u8; 32],
-    public_key_y: [u8; 32],
-    signature: [u8; 64],
-    message_hash: [u8],
-) -> bool
-// docs:end:ecdsa_secp256r1_slice
-{}

test_programs/noir_test_success/comptime_blackbox/src/main.nr

@@ -47,7 +47,7 @@ fn test_blake3() {
 /// Test that ecdsa_secp256k1 is implemented.
 #[test]
 fn test_ecdsa_secp256k1() {
-    let (valid_array, valid_slice) = comptime {
+    let valid = comptime {
         let pub_key_x: [u8; 32] = hex_to_bytes(
             "a0434d9e47f3c86235477c7b1ae6ae5d3442d49b1943c2b752a68e2a47e247c7",
         )
@@ -65,25 +65,15 @@ fn test_ecdsa_secp256k1() {
         )
             .as_array();
 
-        let valid_array =
-            std::ecdsa_secp256k1::verify_signature(pub_key_x, pub_key_y, signature, hashed_message);
-        let valid_slice = std::ecdsa_secp256k1::verify_signature_slice(
-            pub_key_x,
-            pub_key_y,
-            signature,
-            hashed_message.as_slice(),
-        );
-
-        (valid_array, valid_slice)
+        std::ecdsa_secp256k1::verify_signature(pub_key_x, pub_key_y, signature, hashed_message)
     };
-    assert(valid_array);
-    assert(valid_slice);
+    assert(valid);
 }
 
 /// Test that ecdsa_secp256r1 is implemented.
 #[test]
 fn test_ecdsa_secp256r1() {
-    let (valid_array, valid_slice) = comptime {
+    let valid = comptime {
         let pub_key_x: [u8; 32] = hex_to_bytes(
             "550f471003f3df97c3df506ac797f6721fb1a1fb7b8f6f83d224498a65c88e24",
         )
@@ -101,18 +91,9 @@ fn test_ecdsa_secp256r1() {
         )
             .as_array();
 
-        let valid_array =
-            std::ecdsa_secp256r1::verify_signature(pub_key_x, pub_key_y, signature, hashed_message);
-        let valid_slice = std::ecdsa_secp256r1::verify_signature_slice(
-            pub_key_x,
-            pub_key_y,
-            signature,
-            hashed_message.as_slice(),
-        );
-        (valid_array, valid_slice)
+        std::ecdsa_secp256r1::verify_signature(pub_key_x, pub_key_y, signature, hashed_message)
     };
-    assert(valid_array);
-    assert(valid_slice);
+    assert(valid);
 }
 
 /// Test that sha256_compression is implemented.