chore: Check an inline always weight threshold during inline info computation #9487
Conversation
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
…ght-threshold' into mv/inline-info-always-inline-weight-threshold
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-reset |
116.8 s |
7.962 s |
14.67 |
rollup-base-public |
36.94 s |
13.86 s |
2.67 |
rollup-block-root-empty |
27.4 s |
22 s |
1.25 |
semaphore-depth-10 |
4.856 s |
0.84 s |
5.78 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
…ights for terminators
There was a problem hiding this comment.
ACVM Benchmarks
| Benchmark suite | Current: 8ea0d79 | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
260375 ns/iter (± 2062) |
262366 ns/iter (± 1014) |
0.99 |
perfectly_parallel_opcodes |
228041 ns/iter (± 3354) |
229023 ns/iter (± 4370) |
1.00 |
perfectly_parallel_batch_inversion_opcodes |
2782398 ns/iter (± 2688) |
2784140 ns/iter (± 2280) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Test Suite Duration
| Benchmark suite | Current: 8ea0d79 | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
99 s |
100 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
129 s |
130 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
225 s |
219 s |
1.03 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
245 s |
209 s |
1.17 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib |
33 s |
33 s |
1 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
103 s |
96 s |
1.07 |
test_report_noir-lang_sha256_ |
15 s |
15 s |
1 |
test_report_noir-lang_sha512_ |
12 s |
13 s |
0.92 |
test_report_zkpassport_noir-ecdsa_ |
1 s |
2 s |
0.50 |
test_report_zkpassport_noir_rsa_ |
2 s |
2 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
Compilation Time
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
2.066 s |
1.756 s |
1.18 |
private-kernel-reset |
116.8 s |
7.962 s |
14.67 |
private-kernel-tail |
1.352 s |
1.428 s |
0.95 |
rollup-base-public |
36.94 s |
13.86 s |
2.67 |
rollup-block-root-empty |
27.4 s |
22 s |
1.25 |
rollup-merge |
1.374 s |
1.41 s |
0.97 |
rollup-root |
1.514 s |
1.582 s |
0.96 |
semaphore-depth-10 |
4.856 s |
0.84 s |
5.78 |
sha512-100-bytes |
1.408 s |
1.758 s |
0.80 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Opcode count
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
14888 opcodes |
14792 opcodes |
1.01 |
private-kernel-reset |
93141 opcodes |
68868 opcodes |
1.35 |
private-kernel-tail |
11177 opcodes |
11177 opcodes |
1 |
rollup-base-public |
404619 opcodes |
159930 opcodes |
2.53 |
rollup-block-root-empty |
82166 opcodes |
68108 opcodes |
1.21 |
rollup-merge |
1409 opcodes |
1409 opcodes |
1 |
rollup-root |
2631 opcodes |
2631 opcodes |
1 |
semaphore-depth-10 |
5700 opcodes |
5700 opcodes |
1 |
sha512-100-bytes |
13090 opcodes |
13173 opcodes |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Opcode count'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-reset |
93141 opcodes |
68868 opcodes |
1.35 |
rollup-base-public |
404619 opcodes |
159930 opcodes |
2.53 |
rollup-block-root-empty |
82166 opcodes |
68108 opcodes |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Execution Time
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.015 s |
0.016 s |
0.94 |
private-kernel-reset |
0.165 s |
0.153 s |
1.08 |
private-kernel-tail |
0.01 s |
0.01 s |
1 |
rollup-base-public |
0.34 s |
0.16 s |
2.13 |
rollup-merge |
0.002 s |
0.003 s |
0.67 |
rollup-root |
0.004 s |
0.004 s |
1 |
semaphore-depth-10 |
0.025 s |
0.021 s |
1.19 |
sha512-100-bytes |
0.1 s |
0.097 s |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Artifact Size
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
711.3 KB |
709.3 KB |
1.00 |
private-kernel-reset |
2436.7 KB |
2032.8 KB |
1.20 |
private-kernel-tail |
535.6 KB |
535.2 KB |
1.00 |
rollup-base-public |
7937.5 KB |
3328.7 KB |
2.38 |
rollup-block-root-empty |
4003 KB |
3855 KB |
1.04 |
rollup-merge |
188.1 KB |
188 KB |
1.00 |
rollup-root |
390.6 KB |
390.6 KB |
1 |
semaphore-depth-10 |
559.1 KB |
631.5 KB |
0.89 |
sha512-100-bytes |
599.2 KB |
525.5 KB |
1.14 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Compilation Memory
| Benchmark suite | Current: 8ea0d79 | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
291.88 MB |
284.79 MB |
1.02 |
private-kernel-reset |
595.56 MB |
594.25 MB |
1.00 |
private-kernel-tail |
264.2 MB |
258.95 MB |
1.02 |
rollup-base-private |
1440 MB |
1350 MB |
1.07 |
rollup-base-public |
1620 MB |
1400 MB |
1.16 |
rollup-block-root-empty |
2480 MB |
1020 MB |
2.43 |
rollup-merge |
336.65 MB |
332.71 MB |
1.01 |
rollup-root |
347.62 MB |
343.45 MB |
1.01 |
semaphore_depth_10 |
106.66 MB |
106.9 MB |
1.00 |
sha512_100_bytes |
197.91 MB |
236.02 MB |
0.84 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Execution Memory
| Benchmark suite | Current: 8ea0d79 | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
private-kernel-inner |
258.14 MB |
258.14 MB |
1 |
private-kernel-reset |
291.33 MB |
291.33 MB |
1 |
private-kernel-tail |
242.94 MB |
242.94 MB |
1 |
rollup-base-private |
503.69 MB |
503.7 MB |
1.00 |
rollup-base-public |
436.08 MB |
436.08 MB |
1 |
rollup-merge |
330.47 MB |
330.47 MB |
1 |
rollup-root |
332.99 MB |
332.99 MB |
1 |
semaphore_depth_10 |
72.43 MB |
72.43 MB |
1 |
sha512_100_bytes |
58.48 MB |
58.23 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 8ea0d79 | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
rollup-block-root-empty |
2480 MB |
1020 MB |
2.43 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
rollup-base-private |
671.19 MB |
503.7 MB |
1.33 |
rollup-base-public |
536.62 MB |
436.08 MB |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
rollup-base-public |
0.34 s |
0.16 s |
2.13 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Artifact Size'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d674d1e | Previous: 5fe0c50 | Ratio |
|---|---|---|---|
rollup-base-public |
7937.5 KB |
3328.7 KB |
2.38 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem*
Resolves #9486
Summary*
I was just looking to show how we could improve our inline infos computation to remove the
inline_simple_functionspass entirely.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.