Skip to content

wpt: properly handle write permissions errors in wpt-runner setup #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

wpt: properly handle write permissions errors in wpt-runner setup #4518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions test/web-platform-tests/wpt-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,18 +407,28 @@ async function setup () {
`The WPT require certain entries to be present in your ${hostsPath} file. Should these be configured automatically? (y/n): `,
resolve
)
}).finally(() => rl.close())
}).finally(() => rl.close()).then((a) => a.trim().toLowerCase())

if (answer.toLowerCase() === 'y' || answer.toLowerCase() === 'yes') {
await setupHostsFile()
} else {
let hostsModified = false
if (answer === 'y' || answer === 'yes') {
try {
await setupHostsFile()
hostsModified = true
} catch (err) {
console.error('❌ \x1B[31mAutomatic configuration failed.\x1B[0m')
}
}
if (!hostsModified) {
console.log('Please configure hosts file manually:')
console.log(`cd ${WPT_DIR}`)
if (process.platform === 'win32') {
console.log('python wpt make-hosts-file | Out-File $env:SystemRoot\\System32\\drivers\\etc\\hosts -Encoding ascii -Append')
} else {
console.log('python3 wpt make-hosts-file | sudo tee -a /etc/hosts')
}

console.log('❌ \x1B[31mSetup incomplete.\x1B[0m')
process.exit(1)
}
}

Expand Down
Loading