Skip to content

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 3, 2025

Fixes #4484
Nightly tests use EOL Node 23, which has no sqlite, nightly now points to node 25 nightly
CodeCov was broken, because wf was generating LCOV information in node 20 but was sending reports in node 22 run

It was always confusing that the ci was in nodejs.yml and the test.yml was the actual reusable workflow. Renamed it.

Workflows for release and other "meta" workflows now use node lts

Unified the name for node-version inputs.
One liners for matrix values seem to be better for managing them.

Checkout Action now uses persists-credentials explicitly set to true or false

Additional information about the built-in deps of nodejs is printed
Using commit hashes for actions

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (e23167b) to head (3ddcb02).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #4513       +/-   ##
=========================================
+ Coverage      0   93.53%   +93.53%     
=========================================
  Files         0      103      +103     
  Lines         0    32349    +32349     
=========================================
+ Hits          0    30257    +30257     
- Misses        0     2092     +2092     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Uzlopak Uzlopak changed the title improve workflows chore: refactor workflows Sep 3, 2025
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 4, 2025

@metcoder95 PTAL

@Uzlopak Uzlopak merged commit ca7a7b2 into main Sep 4, 2025
32 of 35 checks passed
@Uzlopak Uzlopak deleted the codecov branch September 4, 2025 08:33
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly tests are failing
3 participants