Skip to content

test (pool.js): fix flakyness of clientTtl test #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2025
Merged

test (pool.js): fix flakyness of clientTtl test #4494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,9 @@ test('pool connect', async (t) => {
})

test('pool connect with clientTtl specified', async (t) => {
t = tspl(t, { plan: 1 })
t = tspl(t, { plan: 3 })

const server = createServer({ joinDuplicateHeaders: true }, (c) => {
t.fail()
})
const server = createServer({ joinDuplicateHeaders: true }, t.fail)
server.on('connect', (req, socket, firstBodyChunk) => {
socket.write('HTTP/1.1 200 Connection established\r\n\r\n')

Expand All @@ -607,7 +605,7 @@ test('pool connect with clientTtl specified', async (t) => {
path: '/'
})

t.strictEqual(socket.closed, false)
t.strictEqual(socket.closed, false, 'client not closed yet')

let recvData = ''
socket.on('data', (d) => {
Expand All @@ -619,10 +617,12 @@ test('pool connect with clientTtl specified', async (t) => {
})

socket.write('Body')
socket.end()
await new Promise((resolve, reject) => socket.end((e) => e ? reject(e) : resolve()))

t.strictEqual(socket.closed, false, 'client not closed yet')

await new Promise(resolve => setTimeout(resolve, 10))
t.strictEqual(socket.closed, true)
t.strictEqual(socket.closed, true, 'client closed after ttl')
})

await t.completed
Expand Down
Loading