Skip to content

Conversation

KhafraDev
Copy link
Member

refs: #3489

@KhafraDev
Copy link
Member Author

KhafraDev commented Aug 30, 2025

@panva Please let me know what is needed to generate the WPT report properly. 71b9f2b#diff-a86bc35dc4e7553cf23c76c1e41daeb4766cbd6dbb7dab9e95b21cc636ccf6aa (example report)

The report is still be generated the same way:

WPT_REPORT=./output/path.json node --run test:wpt

@panva
Copy link
Member

panva commented Aug 30, 2025

Not sure what you're asking about, isn't a real wpt runner going to generate a proper wpt report for you?

@KhafraDev
Copy link
Member Author

As far as I could find, you can use wpt to generate the report... but only for browsers (wpt run --log-wptreport=report.json product [...tests]). The title of the PR is a little misleading because we're running the real webserver, but we still need to run the tests ourselves.

@KhafraDev KhafraDev marked this pull request as ready for review September 1, 2025 22:44
@KhafraDev KhafraDev changed the title use real wpt test runner use real wpt test server Sep 1, 2025
fix(websocketerror): inheriting DOMException on node v24

refs: nodejs/node#59677

fix(websocket, eventsource): properly set event handlers

fixup

fixup

fixup

fixup

fixup

fixup

fixup

fixup

add WPT report

fixup

fixup

catch failures outside of tests

expand test expectations

add attribution and mark tests as flaky

add attribution and mark tests as flaky

fixup

fixup
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 5ceaf61 into nodejs:main Sep 1, 2025
28 of 30 checks passed
@KhafraDev KhafraDev deleted the real-wpt branch September 2, 2025 00:30
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants