Skip to content

chore: FixedQueue does not need special constructor #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

chore: FixedQueue does not need special constructor #4476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 15 additions & 39 deletions lib/dispatcher/fixed-queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,35 +59,21 @@ const kMask = kSize - 1
* @template T
*/
class FixedCircularBuffer {
constructor () {
/**
* @type {number}
*/
this.bottom = 0
/**
* @type {number}
*/
this.top = 0
/**
* @type {Array<T|undefined>}
*/
this.list = new Array(kSize).fill(undefined)
/**
* @type {T|null}
*/
this.next = null
}
/** @type {number} */
bottom = 0
/** @type {number} */
top = 0
/** @type {Array<T|undefined>} */
list = new Array(kSize).fill(undefined)
/** @type {T|null} */
next = null

/**
* @returns {boolean}
*/
/** @returns {boolean} */
isEmpty () {
return this.top === this.bottom
}

/**
* @returns {boolean}
*/
/** @returns {boolean} */
isFull () {
return ((this.top + 1) & kMask) === this.bottom
}
Expand All @@ -101,9 +87,7 @@ class FixedCircularBuffer {
this.top = (this.top + 1) & kMask
}

/**
* @returns {T|null}
*/
/** @returns {T|null} */
shift () {
const nextItem = this.list[this.bottom]
if (nextItem === undefined) { return null }
Expand All @@ -118,22 +102,16 @@ class FixedCircularBuffer {
*/
module.exports = class FixedQueue {
constructor () {
/**
* @type {FixedCircularBuffer<T>}
*/
/** @type {FixedCircularBuffer<T>} */
this.head = this.tail = new FixedCircularBuffer()
}

/**
* @returns {boolean}
*/
/** @returns {boolean} */
isEmpty () {
return this.head.isEmpty()
}

/**
* @param {T} data
*/
/** @param {T} data */
push (data) {
if (this.head.isFull()) {
// Head is full: Creates a new queue, sets the old queue's `.next` to it,
Expand All @@ -143,9 +121,7 @@ module.exports = class FixedQueue {
this.head.push(data)
}

/**
* @returns {T|null}
*/
/** @returns {T|null} */
shift () {
const tail = this.tail
const next = tail.shift()
Expand Down
Loading