-
-
Notifications
You must be signed in to change notification settings - Fork 666
feat: make UndiciErrors reliable to instanceof #4472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this should be backporrted to v6 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-4472-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f256afdcb49d0502bc61056ad49a829814b25cb
# Push it to GitHub
git push --set-upstream origin backport-4472-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x Then, create a pull request where the |
@Uzlopak can you try to backport it? |
i will try to backport it. Currently doing some other stuff locally. ;) |
* feat: make UndiciErrors reliable to instanceof * also take MockNotMatchedError into account (cherry picked from commit 5f256af)
fixes #3987
This is basically the same approach we use in @fastify/errors
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status