Skip to content

test: remove obsolete < node v18 test case for http2 #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

test: remove obsolete < node v18 test case for http2 #4461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions test/http2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ const pem = require('@metcoder95/https-pem')

const { Client, Agent, FormData } = require('..')

const isGreaterThanv20 = process.versions.node.split('.').map(Number)[0] >= 20

test('Should support H2 connection', async t => {
const body = []
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
Expand Down Expand Up @@ -356,49 +354,6 @@ test('Should throw if bad maxConcurrentStreams has been passed', async t => {

test(
'Request should fail if allowH2 is false and server advertises h1 only',
{ skip: isGreaterThanv20 },
async t => {
t = tspl(t, { plan: 1 })

const server = createSecureServer(
{
...await pem.generate({ opts: { keySize: 2048 } }),
allowHTTP1: false,
ALPNProtocols: ['http/1.1']
},
(req, res) => {
t.fail('Should not create a valid h2 stream')
}
)

server.listen(0)
await once(server, 'listening')

const client = new Client(`https://localhost:${server.address().port}`, {
allowH2: false,
connect: {
rejectUnauthorized: false
}
})

after(() => server.close())
after(() => client.close())

const response = await client.request({
path: '/',
method: 'GET',
headers: {
'x-my-header': 'foo'
}
})

t.strictEqual(response.statusCode, 403)
}
)

test(
'[v20] Request should fail if allowH2 is false and server advertises h1 only',
{ skip: !isGreaterThanv20 },
async t => {
const server = createSecureServer(
{
Expand Down Expand Up @@ -1029,7 +984,7 @@ test('Should handle h2 request with body (iterable)', async t => {
t.strictEqual(Buffer.concat(requestChunks).toString('utf-8'), expectedBody)
})

test('Should handle h2 request with body (Blob)', { skip: !Blob }, async t => {
test('Should handle h2 request with body (Blob)', async t => {
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
const expectedBody = 'asd'
const requestChunks = []
Expand Down
Loading