Skip to content

test: remove skip checks for existance of global available Blob and File #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

test: remove skip checks for existance of global available Blob and File #4460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/client-post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { once } = require('node:events')
const { Client } = require('..')
const { createServer } = require('node:http')

test('request post blob', { skip: !Blob }, async (t) => {
test('request post blob', async (t) => {
t = tspl(t, { plan: 3 })

const server = createServer({ joinDuplicateHeaders: true }, async (req, res) => {
Expand Down Expand Up @@ -42,7 +42,7 @@ test('request post blob', { skip: !Blob }, async (t) => {
await t.completed
})

test('request post arrayBuffer', { skip: !Blob }, async (t) => {
test('request post arrayBuffer', async (t) => {
t = tspl(t, { plan: 3 })

const server = createServer({ joinDuplicateHeaders: true }, async (req, res) => {
Expand Down
3 changes: 1 addition & 2 deletions test/fetch/http2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ test(
strictEqual(Buffer.concat(requestChunks).toString('utf-8'), expectedBody)
}
)
test('Should handle h2 request with body (Blob)', { skip: !Blob }, async (t) => {
test('Should handle h2 request with body (Blob)', async (t) => {
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
const expectedBody = 'asd'
const requestChunks = []
Expand Down Expand Up @@ -303,7 +303,6 @@ test('Should handle h2 request with body (Blob)', { skip: !Blob }, async (t) =>

test(
'Should handle h2 request with body (Blob:ArrayBuffer)',
{ skip: !Blob },
async (t) => {
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
const expectedBody = 'hello'
Expand Down
3 changes: 1 addition & 2 deletions test/http2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ test('Should handle h2 request with body (iterable)', async t => {
t.strictEqual(Buffer.concat(requestChunks).toString('utf-8'), expectedBody)
})

test('Should handle h2 request with body (Blob)', { skip: !Blob }, async t => {
test('Should handle h2 request with body (Blob)', async t => {
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
const expectedBody = 'asd'
const requestChunks = []
Expand Down Expand Up @@ -1093,7 +1093,6 @@ test('Should handle h2 request with body (Blob)', { skip: !Blob }, async t => {

test(
'Should handle h2 request with body (Blob:ArrayBuffer)',
{ skip: !Blob },
async t => {
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
const expectedBody = 'hello'
Expand Down
4 changes: 2 additions & 2 deletions test/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ describe('isBlobLike', () => {
strictEqual(isBlobLike(buffer), false)
})

test('blob', { skip: !Blob }, () => {
test('blob', () => {
const blob = new Blob(['asd'], {
type: 'application/json'
})
strictEqual(isBlobLike(blob), true)
})

test('file', { skip: !File }, () => {
test('file', () => {
const file = new File(['asd'], 'file.txt', {
type: 'text/plain'
})
Expand Down
Loading