fix: EnvHttpProxyAgent.Options should accept ProxyAgent.Options #4243
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
May 28, 2025
|
Can you add some tests to it? |
Merged
Uzlopak
pushed a commit
that referenced
this pull request
Jun 27, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
EnvHttpProxyAgent.Optionsextends fromAgent.Options, so it's not possible to passProxyAgent.Optionssuch asrequestTlsto theEnvHttpProxyAgentconstructor.Changes
EnvHttpProxyAgent.OptionsextendsOmit<ProxyAgent.Options, 'uri'>.uriis omitted, because it's provided byEnvHttpProxyAgent.Features
N/A
Bug Fixes
It's not possible to pass
requestTls(and others) to theEnvHttpProxyAgentconstructor.Breaking Changes and Deprecations
Status