fix: pass down context in onConnect

[DTrombett]

This relates to...

The retry and cache handlers do not pass down the context of the onConnect method. This means that using the redirect handler with one of them will not pass the context to the main handler:

request("http://github.com", {
    dispatcher: new Agent().compose(
        interceptors.redirect({ maxRedirections: 1 }),
        interceptors.retry(),
    ),
}).then((res) => console.log(res.context)); // undefined

request("http://github.com", {
    dispatcher: new Agent().compose(
        interceptors.redirect({ maxRedirections: 1 }),
    ),
}).then((res) => console.log(res.context)) // { history: [URL, URL] }

Rationale

Changes

• Cache handler: used ...args to pass all the args (like in the decorator handler)
• Retry handler: onConnect is now called on the first connection instead that in the constructor, allowing to pass the context

Features

Bug Fixes

Breaking Changes and Deprecations

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[mcollina]

Thanks for opening a PR! Can you please add a unit test?

[metcoder95]

Nice catch

[Uzlopak]

...args is imho not that nice. i think it does not cover in the types or so, that it can have two arguments. only abort.

[DTrombett]

I noticed that ...args is what is used in the decorator handler too, so I assumed it would be ok

[mcollina]

lgtm