fix: assume blocking unless HEAD #3771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
blocking-default
branch
6 times, most recently
from
552e862 to
669781a
Compare
|
Does this affect our benchmarks? |
Yes, if they are using pipelining. |
|
Fixed benchmarks as well. |
ronag
force-pushed
the
blocking-default
branch
from
ffaebbe to
6b663ec
Compare
ronag
commented
Oct 28, 2024
|
With this change we could probably turn pipelining on by default? |
ronag
force-pushed
the
blocking-default
branch
7 times, most recently
from
405d1f5 to
c18ad76
Compare
|
Failing tests seem to be flaky and unrelated |
metcoder95
approved these changes
Oct 29, 2024
This is a safer default.
ronag
force-pushed
the
blocking-default
branch
from
c18ad76 to
aec6f29
Compare
|
@mcollina ping |
flakey5
pushed a commit
to flakey5/undici
that referenced
this pull request
Nov 14, 2024
* disable failing test * fix: assume blocking unless HEAD This is a safer default. * fixup * fixup: benchmark
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a safer default.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status